[
https://issues.apache.org/jira/browse/EMAIL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved EMAIL-167.
------------------------
Resolution: Fixed
Fix Version/s: 1.5
Thanks for the report and patch; applied:
URL: http://svn.apache.org/viewvc?rev=1787115&view=rev
Log:
EMAIL-167 DataSourceClassPathResolver doesn't close InputStream when resolving
resources
Modified:
commons/proper/email/trunk/src/changes/changes.xml
commons/proper/email/trunk/src/main/java/org/apache/commons/mail/resolver/DataSourceClassPathResolver.java
> DataSourceClassPathResolver doesn't close InputStream when resolving resources
> ------------------------------------------------------------------------------
>
> Key: EMAIL-167
> URL: https://issues.apache.org/jira/browse/EMAIL-167
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Lucian Burja
> Fix For: 1.5
>
> Attachments: EMAIL-167-close-input-stream.patch
>
>
> DataSourceClassPathResolver opens an InputStream (via
> .class.getResourceAsStream) to read a resource into a ByteArrayDataSource,
> but never closes it:
> {code}
> public DataSource resolve(final String resourceLocation, final boolean
> isLenient) throws IOException
> {
> ...
> final InputStream is =
> DataSourceClassPathResolver.class.getResourceAsStream(resourceName);
> if (is != null)
> {
> final ByteArrayDataSource ds = new
> ByteArrayDataSource(is, mimeType);
> // EMAIL-125: set the name of the DataSource to the
> normalized resource URL
> // similar to other DataSource implementations, e.g.
> FileDataSource, URLDataSource
>
> ds.setName(DataSourceClassPathResolver.class.getResource(resourceName).toString());
> result = ds;
> }
> {code}
> The 'is' variable above should be closed in a try ... finally
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
