[ 
https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939789#comment-15939789
 ] 

Makoto Sakaguchi edited comment on NET-630 at 3/24/17 8:27 PM:
---------------------------------------------------------------

I suppose to need three new classes for supporting IPv6, which is two classes 
with IPv4 and IPv6 subnet functions and an abstract class of the functions.
So, I created a new package, which is subnet in the util package, and placed 
them there; the package was removed.

At least, the subclass in SubnetUtils, SubnetInfo, had better to be a separate 
class for future maintenance.


was (Author: umoxfo):
I suppose to need three new classes for supporting IPv6, which is two classes 
with IPv4 and IPv6 subnet functions and an abstract class of the functions.
So, I created a new package, which is subnet in the util package, and placed 
them there.
At least, the subclass in SubnetUtils, SubnetInfo, must be a separate class for 
future maintenance.

> NET-630 Changed SubnetUtils for NEW SubnetInfo subclass
> -------------------------------------------------------
>
>                 Key: NET-630
>                 URL: https://issues.apache.org/jira/browse/NET-630
>             Project: Commons Net
>          Issue Type: Sub-task
>            Reporter: Makoto Sakaguchi
>
> The constructors of this class has been modified to create a object of subnet 
> summary information.
> Also, added two new static methods to create the object.
> Change log
> * *Renamed getAddressCount() to getAddressCountString()*
> ** The old name, getAddressCount(), was the obsoleted name and confused 
> others.
> * Moved IP4Subnet and IP6Subnet classes into the until package.
> * Removed the insignificant value representation, which are no reasons to be 
> defined in this class.
> * Improved comments
> https://github.com/apache/commons-net/pull/25



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to