[
https://issues.apache.org/jira/browse/COMPRESS-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969187#comment-15969187
]
Stefan Bodewig commented on COMPRESS-385:
-----------------------------------------
Thanks Tim, looks good, Tim. One minor nit though, you don't need to change the
RELEASE-NOTES and your change would actually be wrong. It gets auto-created
during the release process from {{src/changes/changes.xml}} so you may want to
modify that.
I agree the change for the case of a missing XZ for Java library is better than
what we had before, we may want to add a note about the change to the
changelog, though. The change isn't big, it's really only the error message
that will be different.
Clean build worked for me, maybe it depends on the OS, version of the JDK or
Maven? Linux, 1.8 (b121) and 3.3.9 here.
Finally we probably want to do the same to {{ArchiveStreamFactory}}, do you
want to take a stab at it as well? "no" is a very acceptable answer ;-)
> Add detect() to CompressorStreamFactory
> ---------------------------------------
>
> Key: COMPRESS-385
> URL: https://issues.apache.org/jira/browse/COMPRESS-385
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Tim Allison
> Priority: Minor
> Fix For: 1.14
>
>
> On TIKA-1631, several users have requested that we try to avoid an OOM when a
> corrupted Z file is "detected" by CompressorStreamFactory.
> In Tika, for detection, we're creating the stream via CompressorStreamFactory
> and then "detecting" based on what stream was created. Given that there can
> be some overhead in creating the stream and that there can be an OOM for a
> corrupt Z file, it would be great to add a {{detect(InputStream is)}} option
> in CompressorStreamFactory.
> PR on way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
