[ 
https://issues.apache.org/jira/browse/LANG-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990701#comment-15990701
 ] 

Bruno P. Kinoshita commented on LANG-1325:
------------------------------------------

Checked out pull request locally, created Maven site with and without the pull 
request test. The current code has line coverage of 70%, and branch coverage of 
91%. With the code in the pull request we get 99% line coverage (though it 
looks to be 100%), and branch coverage of 100%. Had a look at the test, and 
everything looks OK.

Code well formatted, no tabs found, everything seems to have been correctly 
updated. Will merge the pull request now, and update changes.xml.

Great work, props to [~arshad0789]. Thank you.
Bruno

> Increase test coverage of ToStringBuilder class to 100%
> -------------------------------------------------------
>
>                 Key: LANG-1325
>                 URL: https://issues.apache.org/jira/browse/LANG-1325
>             Project: Commons Lang
>          Issue Type: Test
>            Reporter: Arshad Basha
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>
> Adding test cases to test the following methods of ToStringBuilder, with 
> this, the code coverage stands at 100%.
> 1)  append(final String fieldName, final boolean[] array)
> 2) append(final String fieldName, final boolean[] array, final boolean 
> fullDetail)
> 3) append(final String fieldName, final byte[] array)
> 4) append(final String fieldName, final byte[] array, final boolean 
> fullDetail)
> 5) append(final String fieldName, final char[] array)
> 6) append(final String fieldName, final char[] array, final boolean 
> fullDetail)
> 7) append(final String fieldName, final double[] array)
> 8) append(final String fieldName, final double[] array, final boolean 
> fullDetail)
> 9) append(final String fieldName, final float[] array)
> 10) append(final String fieldName, final float[] array, final boolean 
> fullDetail)
> 11) append(final String fieldName, final int[] array)
> 12) append(final String fieldName, final int[] array, final boolean 
> fullDetail)
> 13) append(final String fieldName, final long[] array)
> 14) append(final String fieldName, final long[] array, final boolean 
> fullDetail)
> 15) append(final String fieldName, final Object[] array)
> 16) append(final String fieldName, final Object[] array, final boolean 
> fullDetail)
> 17) append(final String fieldName, final short[] array)
> 18) append(final String fieldName, final short[] array, final boolean 
> fullDetail)
> 19) appendAsObjectToString(final Object srcObject)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to