[
https://issues.apache.org/jira/browse/LANG-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990708#comment-15990708
]
ASF GitHub Bot commented on LANG-1164:
--------------------------------------
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/209
+1 lgtm
Looks useful, I've wanted that feature a couple of times when using
ReflectionToStringBuilder in the past.
Merging the code locally, the build passes, all reports look good but
Chekstyle.
```
org/apache/commons/lang3/builder/ToStringStyle.java
Severity Category Rule Message Line
Error blocks NeedBraces 'if' construct must use '{}'s. 474
Error blocks NeedBraces 'if' construct must use '{}'s. 908
Error blocks NeedBraces 'if' construct must use '{}'s. 1005
Error blocks NeedBraces 'if' construct must use '{}'s. 1067
Error blocks NeedBraces 'if' construct must use '{}'s. 1129
Error blocks NeedBraces 'if' construct must use '{}'s. 1191
Error blocks NeedBraces 'if' construct must use '{}'s. 1253
Error blocks NeedBraces 'if' construct must use '{}'s. 1315
Error blocks NeedBraces 'if' construct must use '{}'s. 1377
Error blocks NeedBraces 'if' construct must use '{}'s. 1439
```
The inlined if fails with our current checkstyle rules. Other than that,
all looks good :-)
> allow ToStringStyle to omitNulls
> --------------------------------
>
> Key: LANG-1164
> URL: https://issues.apache.org/jira/browse/LANG-1164
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
> Reporter: Shaun A Elliott
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
