Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/269#discussion_r120549733
--- Diff:
src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java ---
@@ -316,7 +317,7 @@ public void testReflectionHierarchyArrayList() {
// representation different for IBM JDK 1.6.0, LANG-727
assumeFalse("IBM Corporation".equals(SystemUtils.JAVA_VENDOR) &&
"1.6".equals(SystemUtils.JAVA_SPECIFICATION_VERSION));
assumeFalse("Oracle Corporation".equals(SystemUtils.JAVA_VENDOR)
&& "1.6".compareTo(SystemUtils.JAVA_SPECIFICATION_VERSION) < 0);
- final List<Object> list = new ArrayList<>();
+ final List<Object> list = new
ArrayList<>(arraylistInitialCapacity);
--- End diff --
Sorry to be nitpicking, but this should be a constant and wie should add a
comment referencing JIRA-1337 with an explanation why we need to pass the
initial capacity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
