[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045798#comment-16045798
 ] 

Bruno P. Kinoshita commented on FILEUPLOAD-268:
-----------------------------------------------

[~umutawakil] if you are familiar with GitHub, you can fork 
https://github.com/apache/commons-fileupload under your account, modify the 
code in a branch, and then submit a pull request to the apache repository (see 
[GitHub's article on pull requests for 
more|https://help.github.com/articles/about-pull-requests/]).

That way others can review your changes, comment, etc.

I think it currently throws Exception as there is no generic exception yet. See 
the DiskFileItem implementation fo FileItem, which throws a 
FileUploadException. Other implementations can simply implement the interface 
and then throw their own custom exception. Probably a generic exception as you 
suggests would have some benefit here, but we can discuss that over some code 
(always easier).

Hope that helps,

Cheers
Bruno

> fileItem.write(File file) Throws generic Exception
> --------------------------------------------------
>
>                 Key: FILEUPLOAD-268
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-268
>             Project: Commons FileUpload
>          Issue Type: Improvement
>            Reporter: Usman Mutawakil
>            Priority: Minor
>
> It might be helpful if the call to fileItem.write() threw a more 
> appropriately named exception. I've never had this exception actually get 
> thrown so I have no idea whether or not the exception message is detailed so 
> I wrap it in my own FileItemException.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to