[
https://issues.apache.org/jira/browse/COMPRESS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052311#comment-16052311
]
ASF GitHub Bot commented on COMPRESS-412:
-----------------------------------------
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-compress/pull/35
Compress 412
Fixed Jira issue Compress 412:
https://issues.apache.org/jira/browse/COMPRESS-412
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-compress COMPRESS-412
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 2f45456527f2631ef8b4bb09aa0ad30afda02b5f
Author: Michael Hausegger <[email protected]>
Date: 2017-06-13T21:47:50Z
add-some-Unit-Tests Added some Unit Tests to increase code coverage.
commit 96ca8ceeddbd20ec38b9211260b4b91107b0be2d
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:12:20Z
add-some-Unit-Tests Removed @author tags in comments.
commit 5e5dc7f032ffb5b3818410e23d7881a8def46f3d
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:22:10Z
add-some-Unit-Tests Removed test testGetValueThrowsNullPointerException in
class ChecksumCalculatingInputStreamTest. Test represented a bug/defect which
is going to be fixed in a different branch.
commit be0f11f4dbffb5ca1f903a6f07de744687d303c3
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:38:00Z
add-some-Unit-Tests Minor variable renaming.
commit 3b46bb5dc3aeb3ca68062c10589e049c9eb8551d
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:44:40Z
add-some-Unit-Tests Added myself as contributor to pom.xml as "requested"
by Stefan Bodewig.
commit a0e5dd80b9ec43c315021701f9c2334be45c6271
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T19:30:03Z
COMPRESS-412 NullPointerException defect in
ChecksumCalculatingInputStream#getValue() fixed.
----
> NullPointerException defect in ChecksumCalculatingInputStream#getValue()
> ------------------------------------------------------------------------
>
> Key: COMPRESS-412
> URL: https://issues.apache.org/jira/browse/COMPRESS-412
> Project: Commons Compress
> Issue Type: Bug
> Reporter: Michael Hausegger
> Priority: Minor
>
> NullPointerException defect in ChecksumCalculatingInputStream#getValue()
> detected as stated in pull request 33:
> https://github.com/apache/commons-compress/pull/33
> Furthermore the following test describes the problem:
> {code:java}
> @Test(expected = NullPointerException.class) //I assume this behaviour to
> be a bug or at least a defect.
> public void testGetValueThrowsNullPointerException() {
> ChecksumCalculatingInputStream checksumCalculatingInputStream = new
> ChecksumCalculatingInputStream(null,null);
> checksumCalculatingInputStream.getValue();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
