[ 
https://issues.apache.org/jira/browse/COMPRESS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052974#comment-16052974
 ] 

Stefan Bodewig commented on COMPRESS-411:
-----------------------------------------

I think the binary encoding should now be correct, the major problem was using 
{{0xff<<bits}} rather than {{0xffl<<bits}} when we wanted to set the most 
significant byte.

> TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary
> ---------------------------------------------------------------------------
>
>                 Key: COMPRESS-411
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-411
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>
> if the length < 9, formatLongBinary is executed, then overwritten by the 
> results of formatBigIntegerBinary. 
> If the results are not ignored, a unit test would fail.
> Also, do the binary hacks  need to support negative numbers? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to