[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060069#comment-16060069
]
Gilles commented on TEXT-93:
----------------------------
Amey,
Referring to the PR; this code
{code}
public Builder selectFromList(List<Character> characterList) {
this.characterList = characterList;
return this;
}
{code}
is unsafe; better make a defensive copy (like for the {{char[]}} version).
> RandomStringGenerator accepts a list of valid characters
> --------------------------------------------------------
>
> Key: TEXT-93
> URL: https://issues.apache.org/jira/browse/TEXT-93
> Project: Commons Text
> Issue Type: Wish
> Reporter: Wilson MacGyver
>
> implement a "selectFrom" feature:
> RandomStringGenerator gen = new RandomStringGenerator.Builder()
> .selectFrom(charArray)
> .build();
> so we can pass a list of valid characters
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
