[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061891#comment-16061891
]
ASF GitHub Bot commented on TEXT-93:
------------------------------------
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/54#discussion_r123874569
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -76,23 +78,29 @@
private final TextRandomProvider random;
/**
+ * The source of provided charachters.
+ */
+ private final List<Character> characterList;
+
+ /**
* Constructs the generator.
- *
- * @param minimumCodePoint
+ * @param minimumCodePoint
* smallest allowed code point (inclusive)
* @param maximumCodePoint
* largest allowed code point (inclusive)
* @param inclusivePredicates
- * filters for code points
- * @param random
- * source of randomness
+ * filters for code points
--- End diff --
Indentation got a bit messed up here, and the param entry for
minimumCodePoint too
> RandomStringGenerator accepts a list of valid characters
> --------------------------------------------------------
>
> Key: TEXT-93
> URL: https://issues.apache.org/jira/browse/TEXT-93
> Project: Commons Text
> Issue Type: Wish
> Reporter: Wilson MacGyver
>
> implement a "selectFrom" feature:
> RandomStringGenerator gen = new RandomStringGenerator.Builder()
> .selectFrom(charArray)
> .build();
> so we can pass a list of valid characters
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
