[
https://issues.apache.org/jira/browse/CODEC-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176769#comment-16176769
]
Sebb commented on CODEC-234:
----------------------------
The setAllowLookalikes method changes a shared static table.
That is not thread-safe; in fact it is thread-hostile.
Setters generally cause issues for thread-safety, even when used on instance
data.
But the change to allow lowercase decoding looks OK.
I think it would be better to use a separate JIRA issue for the 0/1 enhancement
request.
> Base32.decode should support lowercase letters
> ----------------------------------------------
>
> Key: CODEC-234
> URL: https://issues.apache.org/jira/browse/CODEC-234
> Project: Commons Codec
> Issue Type: Improvement
> Affects Versions: 1.10
> Reporter: Christopher Schultz
> Priority: Minor
> Attachments: CODEC-234-2.diff, CODEC-234.diff
>
>
> Base32.decode accepts a String input, but any lowercase characters are
> ignored -- e.g. Base32.decode("abcd2345") will give a different result than
> Base32.decode("ABCD1234") with no errors and a surprise to a developer.
> Accepting any case is desirable, as RFC 4648 makes it clear that
> case-insensitivity is a goal for Base32 encoding.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
