[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189554#comment-16189554
]
Gilles commented on RNG-37:
---------------------------
Hi Olga.
I've just quickly read through the proposed code; here are a few remarks:
* Please add a link (web page, paper, code) to the reference(s) which you used
for the implementation.
* Please follow the coding style (e.g. "space" around operators). Running "mvn
site" should produce a clean "CheckStyle" report.
* Magic numbers should be avoided; use a "static final" instance field instead.
* Constants should be declared "final".
* Reuse already computed values (cf. lines 56, 65, 71 and lines 102, 103, ...)
* Javadoc must be provided for all method and fields ("private" also).
Did you check the performance?
Thanks a lot for your interest in, and contribution to, the "Commons RNG"
project!
> Ziggurat algorithm
> ------------------
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
> Reporter: Gilles
> Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
