Github user namannigam commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r147422522
  
    --- Diff: src/main/java/module-info.java ---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/**
    + * Apache Commons Lang provides utility classes for the core of Java.
    + */
    +module org.apache.commons.lang3 {
    +
    +    // see AbstractCircuitBreaker
    +    requires static java.desktop;
    --- End diff --
    
    a small difference and I am just curious to know, why is this not 
`transitive` which was what I saw using `jdeps --generate-module-info`?


---

Reply via email to