[
https://issues.apache.org/jira/browse/COLLECTIONS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240097#comment-16240097
]
ASF GitHub Bot commented on COLLECTIONS-664:
--------------------------------------------
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/33
Hi @zhangminglei !
Sure. Few questions from reviewing the JIRA ticket and the pull request.
* Why Commons Collections? The SortedProperties uses Java collection
classes to sort its keys. But FileProperties doesn't seem to have much to do
with Java collections.
* The name of the class doesn't really suggest what it does. Unless there
are other use cases, we could be more specific about the class name.
* However, I suspect this code belongs more to the user code, and not
really to the low level library. Might be better to update the ticket to
Commons Configuration maybe (?), and send a message to the development mailing
list in case you don't hear back within some days.
The code is well written, and with tests :-) we just need to review the use
case, and which component could host it.
Hope it helps
Bruno
> Add class FileProperties to load file name directly
> ---------------------------------------------------
>
> Key: COLLECTIONS-664
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-664
> Project: Commons Collections
> Issue Type: New Feature
> Reporter: mingleizhang
>
> For example, In some interface, needs we have a {{java.util.Properties}} as a
> parameter. In common case, we have different profiles in maven under
> different environments that we can random selection. And use the current
> classloader, usually belongs to AppclassLoader to get it's inputstream. I
> propose we should add a functionality that can directly read a file name and
> return a {{java.util.Properties}} as a return value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
