[
https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275516#comment-16275516
]
Gilles commented on NUMBERS-50:
-------------------------------
bq. the only issues I found was in target of the complex
Do you mean in directory {{commons-numbers-complex/target}}?
When I call {{mvn site}}, CheckStyle does not report anything there! How do
you call the report generation in order to get a different result?
In other modules, CheckStyle does report a few errors (e.g.
{{HideUtilityClassConstructor}}) that would become hidden with the new
suppressions. I rather think that we should heed the suggestions from
CheckStyle unless there is a good reason.
bq. other suppressions are valid
At first sight I wouldn't agree. Was there a ML discussion about those
suppressions?
bq. copied from commons text
Indeed, there are references to classes that don't exist in "Numbers"...
I also tend to think that failing the build because of picky rules (like
trailing whitespace) may not be pleasant when developing.
IIRC, there was a discussion about mandating that contributors should run a
specific command (with options that would then fail the build, namely if
CheckStyle is not happy) before submitting a pull request. But I don't recall
that it has been done.
> Clean checkstyle for Complex
> ----------------------------
>
> Key: NUMBERS-50
> URL: https://issues.apache.org/jira/browse/NUMBERS-50
> Project: Commons Numbers
> Issue Type: Bug
> Reporter: Eric Barnhill
> Priority: Trivial
>
> Clean up trailing whitespaces and other checkstyle violations in
> commons-numbers-complex
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
