[ 
https://issues.apache.org/jira/browse/IMAGING-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277488#comment-16277488
 ] 

Bruno P. Kinoshita commented on IMAGING-209:
--------------------------------------------

Thanks for creating the ticket with a good summary of the problem, and for the 
pull request. Code looks clean, plus a unit test (thanks a lot for that as 
well!). Just need to read the code with more calm to properly understand the 
problem before merging it (never used that parser). But nothing looks out of 
place for this pull request. Will try to review it by the next weekend/or next 
days.

Cheers
Bruno

> PnmImageParser throws ImageWriteException when writing if 
> PnmImageParser.PARAM_KEY_PNM_RAWBITS is provided
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: IMAGING-209
>                 URL: https://issues.apache.org/jira/browse/IMAGING-209
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: PNM
>            Reporter: Isak W
>
> Code sample:
> {code:java}
> Map<String, Object> params = new HashMap<>();
> params.put(PnmImageParser.PARAM_KEY_PNM_RAWBITS, 
> PnmImageParser.PARAM_VALUE_PNM_RAWBITS_YES);
> Imaging.writeImage(image, file, ImageFormats.PNM, params);
> {code}
> Error message is: "Unknown parameter: PNM_RAWBITS:
> This happens because used parameters are cleared from the map after usage and 
> any remaining parameters are determined to be unknown, but 
> PnmImageParser.PARAM_KEY_PNM_RAWBITS is never cleared.
> I will provide a patch on Github shortly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to