[ 
https://issues.apache.org/jira/browse/IO-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285795#comment-16285795
 ] 

Sebb commented on IO-443:
-------------------------

If the output size were checked before the file is closed but after it is 
flushed, that should catch actual copy errors (assuming the input does not 
change) regardless of subsequent changes to the destination.

I think the question here is: what is the check really for?

> FileUtils.copyFile methods throw an unnecessary "Failed to copy full contents 
> from" exception 
> ----------------------------------------------------------------------------------------------
>
>                 Key: IO-443
>                 URL: https://issues.apache.org/jira/browse/IO-443
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.4
>         Environment: Win x86  32 bit
>            Reporter: Sami Nieminen
>
> The private doCopyFile method of FileUtils does a comparison between the 
> source and destination file sizes after the data has been copied. 
> If the destination file has been removed, renamed, or otherwise no more 
> accessible (remote share no more available) between the finally block and the 
> size comparison the destFile.length() returns zero. If the source file is not 
> zero bytes in size an exception with the message "Failed to copy full 
> contents from '" + srcFile + "' to '" + destFile " will be thrown.
> Regards
> Sami



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to