[
https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300149#comment-16300149
]
Gilles commented on MATH-1436:
------------------------------
Hello.
Thank you for the report and fixes.
bq. These are two separate issues
Would you mind making two separate patches to help tracking of the changes?
Thanks.
Also, as I'm not knowledgeable in this part of the codebase, could you perhaps
write a more elaborate comment to describe the new statements (e.g. around line
850 in "PolygonsSet.java").
bq. Pull request for v3.6.x
No release based on the 3.x branch is planned anymore.
A few weeks ago, there was a discussion (on the "dev" ML, see
[archive|http://markmail.org/message/75vuyhzblfadc5op]) to move the contents of
package {{org.apache.commons.math4.geometry}} into a component of its own (i.e.
"Commons Geometry") as part of a major overhaul towards modularizing "Commons
Math" which, in the current circumstances, is not maintainable as a monolithic
library.
Work is underway: components ["Commons RNG"|https://commons.apache.org/rng] and
["Commons Numbers"|https://commons.apache.org/numbers] have already been
created.
As a user, your input is important; and you are most welcome to help getting
there.
> PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
> ----------------------------------------------------------------
>
> Key: MATH-1436
> URL: https://issues.apache.org/jira/browse/MATH-1436
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 4.0, 3.5, 3.6, 3.6.1
> Reporter: Matt Juntunen
> Fix For: 4.0, 3.6.1
>
>
> These are two separate issues that I found while using the partitioning code
> from 3.5 to work with complex solid models. The issues are:
> 1. org.apache.commons.math[34].geometry.euclidean.oned.SubOrientedPoint uses
> a hardcoded tolerance of 1.0e-10 instead of the tolerance from the parent
> hyperplane. This causes issues when working with a tolerance other than the
> default.
> 2. org.apache.commons.math[34].geometry.euclidean.twod.PolygonsSet fails on
> infinite line segments. An IndexOutOfBoundsException is thrown when a
> PolygonsSet is created with a single infinite SubLine as a boundary and a
> NullPointerException is thrown when one is created with a mix of finite and
> finite boundaries.
> I will be attaching a pull request shortly with fixes and unit tests.
> UPDATE:
> Pull request for v4.0: https://github.com/apache/commons-math/pull/70
> Pull request for v3.6.x: https://github.com/apache/commons-math/pull/71
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
