Otto Fowler commented on LANG-1373:


Inner class rework done, java doc and test coverage holding ;)

To sum up what I think are the  other suggestions/questions:
 * I don't think throwing an exception or ? to get the Stack info just to keep 
from naming a timing is in line with the purpose of the feature, for 
performance reasons.  If there is a really slick and performant way in commons 
already I'd like to see it?
 * I think a fluid interface adds more complexity than required at this time
 * I think Generic timingName values are also a little too complex


Two other things:
 * Thank you [~kinow] and [~erans] for the review, I always learn a lot from 
these, and I think it is better now than when I started for sure
 * [~erans], how do you pronounce your name?  I'd like to say it right in my 
head when I read it ;)



> Stopwatch based capability for nested, named, timings in a call stack
> ---------------------------------------------------------------------
>                 Key: LANG-1373
>                 URL: https://issues.apache.org/jira/browse/LANG-1373
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.time.*
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
> While working on adding some timing functionality to a Metron feature, I came 
> across the
> Stopwatch class, but found that it didn’t suite my needs.
> What I wanted to do was to create a timing from a top level function in our 
> Stellar dsl, and have have a group of related timings, such that the end 
> result was the overall time of the call, and nested timings of other calls 
> executed during the dsl execution of that function. These timings would all 
> be named, and have a path for identification and include timing the language 
> compiler/execution as well as the function execution itself. It would be 
> helpful if they were tagged in some way as well, such that the consumer could 
> filter during visitation.
> So I have written StackWatch to provide this functionality, and submitted it 
> in a Metron PR.
> From the PR description:
> StackWatch
> A set of utility classes under the new package stellar.common.timing have 
> been added. These provide the StackWatch functionality.
> StackWatch provides an abstraction over the Apache Commons StopWatch class 
> that allows callers to create multiple named and possibly nested timing 
> operations.
> <…>
> This class may be more generally useful to this and other projects, but I am 
> not sure where it would live since we wouldn’t want it in common.
> StackWatch uses a combination of Deque and a custom Tree implementation to 
> create, start and end timing operations.
> A Visitor pattern is also implemented to allow for retrieving the results 
> after the completion of the operation.

This message was sent by Atlassian JIRA

Reply via email to