[ 
https://issues.apache.org/jira/browse/CSV-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved CSV-223.
------------------------------
       Resolution: Fixed
         Assignee: Gary Gregory
    Fix Version/s: 1.6

Patch applied. Thank you for the PR. Please verify and close this ticket.

> Inconsistency between Javadoc of  CSVFormat DEFAULT EXCEL
> ---------------------------------------------------------
>
>                 Key: CSV-223
>                 URL: https://issues.apache.org/jira/browse/CSV-223
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Samuel Martin
>            Assignee: Gary Gregory
>            Priority: Minor
>             Fix For: 1.6
>
>
> According to the [Javadoc of 
> CSVFormat|https://commons.apache.org/proper/commons-csv/archives/1.5/apidocs/index.html]
>  
>  * {{CSVFormat.DEFAULT}} includes among its settings 
> {{withIgnoreEmptyLines(true)}}
>  * {{CSVFormat.EXCEL}} includes among its settings 
> {{withIgnoreEmptyLines(false)}}
>  * Then, the same documentation of {{CSVFormat.EXCEL}} reads that 
> {quote}Note: this is currently like RFC4180 plus 
> withAllowMissingColumnNames(true).{quote}
> One of these three must be wrong (both ignore empty lines, or neither ignores 
> empty lines, or there is another difference that needs to be mentioned).
> Edit: after checking the source code, I conclude that the latest sentence is 
> incomplete, and should also mention {{withIgnoreEmptyLines(false)}} as a 
> difference with {{DEFAULT}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to