[ 
https://issues.apache.org/jira/browse/LANG-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429803#comment-16429803
 ] 

Gary Gregory edited comment on LANG-1389 at 4/8/18 4:37 PM:
------------------------------------------------------------

Looking at JavaVersion and SystemUtils, the code still seems useful, even the 
JavaVersion enum. It just need to be re-implemented with Java 9. Certainly 
methods like {{org.apache.commons.lang3.SystemUtils.IS_JAVA_1_8}} do not need 
to go away, same for JavaVersion. It is nicer to write a switch on an enum than 
an int magic number IMO. 

Thoughts?


was (Author: garydgregory):
Looking at JavaVersion and SystemUtils, the code still seems useful, even the 
JavaVersion enum. It just need to be re-implemented with Java 9. Certainly 
methods like {{org.apache.commons.lang3.SystemUtils.IS_JAVA_1_8}} do not need 
to go away, same for JavaVersion. It is nicer to write a switch on an enum than 
an int IMO. 

Thoughts?

> Deprecate JavaVersion in favor of java.lang.Runtime.Version
> -----------------------------------------------------------
>
>                 Key: LANG-1389
>                 URL: https://issues.apache.org/jira/browse/LANG-1389
>             Project: Commons Lang
>          Issue Type: Task
>          Components: lang.*
>    Affects Versions: 3.7
>            Reporter: Michael Osipov
>            Priority: Major
>
> With the rapid release cycle of Java {{JavaVersion}} does not really work 
> anymore. We at Maven have constant issues with our subprojects for missing 
> Java version in {{JavaVersion}} enum. To solve this problem, Commons Lang 
> must be release at least every six months and we have re-release all affected 
> components. Since this does not scale, I would recommend to deprecate this 
> enum in favor of {{java.lang.Runtime.Version}} or have a better non-enum 
> approach to it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to