[
https://issues.apache.org/jira/browse/POOL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435701#comment-16435701
]
Gary Gregory edited comment on POOL-338 at 4/12/18 2:42 PM:
------------------------------------------------------------
I see what you mean here, but.. I would like you to try my patch
(https://issues.apache.org/jira/secure/attachment/12918586/commons-pool-gg.patch)
as it introduces your idea that I do want to have, namely adding:
{{ BaseObjectPoolConfig.setEvictionPolicy(EvictionPolicy<T> evictionPolicy)}}
{{ BaseObjectPoolConfig.getEvictionPolicy()}}
Gary
was (Author: garydgregory):
I see what you mean here, but.. I would like you to try my patch as it
introduces your idea that I do want to have, namely adding:
{{ BaseObjectPoolConfig.setEvictionPolicy(EvictionPolicy<T> evictionPolicy)}}
{{ BaseObjectPoolConfig.getEvictionPolicy()}}
Gary
> GenericObjectPool constructor throws an exception
> -------------------------------------------------
>
> Key: POOL-338
> URL: https://issues.apache.org/jira/browse/POOL-338
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 2.4.2, 2.4.3, 2.5.0
> Environment: Java 8, Liferay DXP (an OSGi environment).
> Reporter: Michael C
> Priority: Major
> Attachments: commons-pool-gg.patch
>
>
> Version 2.4.3 GenericObjectPool constructor throws this exception:
> {{java.lang.IllegalArgumentException:
> [org.apache.commons.pool2.impl.DefaultEvictionPolicy] does not implement
> EvictionPolicy}}
> {{ at
> org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:618)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:318)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:115)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:88)}}
>
> Version 2.5.0 throws the same exception. Version 2.4.2 or older's
> setEvictionPolicyClassName method fail silently for the same reason. This
> line in BaseGenericObjectPool evaluates to false for all versions:
> {{ if (policy instanceof EvictionPolicy<?>) {}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
