[ 
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462240#comment-16462240
 ] 

Gilles commented on MATH-1459:
------------------------------

I've already fixed the tolerance typo (1e14 vs 1e-14); thanks.

Please run
{noformat}
$ mvn site
{noformat}
It will generate various reports in the {{target/site}} directory so that you 
can verify that your submission does not trigger "CheckStyle" warnings. All 
methods and fields must be documented.

I also think that the unit test class is problematic as it will run many tests 
(from the base class) that are not impacted by the overridden "builder".

As for the feature itself, I wonder whether the differentiator should be a 
parameter (of some factory method); that way, the user would be responsible for 
the possible caveats that currently only appear as warnings in the doc.

> Create a way to calculate the Jacobian Matrix using a Differentiator
> --------------------------------------------------------------------
>
>                 Key: MATH-1459
>                 URL: https://issues.apache.org/jira/browse/MATH-1459
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 4.X
>            Reporter: adrian
>            Priority: Minor
>             Fix For: 4.X
>
>
> Create a way to automatically calculateĀ a Jacobian Matrix using a 
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit:  https://github.com/apache/commons-math/pull/84



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to