[
https://issues.apache.org/jira/browse/CONFIGURATION-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479601#comment-16479601
]
Oliver Heger commented on CONFIGURATION-701:
--------------------------------------------
Patch looks good to me. I have the following minor nits:
* The @since tag on the new method should be for version 2.3.
* It is probably not necessary to change the type of the _configList_ field
from _List_ to _LinkedList_. To add an element at the beginning, just use
{{[add|https://docs.oracle.com/javase/8/docs/api/java/util/List.html#add-int-E-](int
index, [E|https://docs.oracle.com/javase/8/docs/api/java/util/List.html]
element). }}I think that _LinkedList_ will handle this efficiently.
When this is done, I am happy to apply the patch.
> Add support to CompositeConfiguration to allow Configurations to be prepend
> to the LinkedList
> ---------------------------------------------------------------------------------------------
>
> Key: CONFIGURATION-701
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-701
> Project: Commons Configuration
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Nicholas Verbeck
> Priority: Minor
> Attachments: CONFIGURATION-701.patch
>
>
> Create methods like addFirstConfiguration with similar signatures as
> addConfiguration but instead of appending them to the LinkedList add them to
> the start of the list. This would allow for support of inserting new override
> configs post initial construction without needing to rebuild a new
> CompositeConfiguration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
