[
https://issues.apache.org/jira/browse/POOL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael C reopened POOL-338:
----------------------------
Turns out _commons-pool-mm.patch_ applied to master does not resolve the
original problem of GenericObjectPoll constructor. The alternative
{{epClassLoader}} in {{BaseGenericObjectPool.setEvictionPolicyClassName(,)}} is
never used, because execution never reaches the inner-most catch.
Therefore, we need the same thing from _commons-pool-2.5.1.patch_ for 2.6,
which is attached as _commons-pool-2.6.0.patch_. I don't see a way to submit
PR, probably because I am not a committer.
> GenericObjectPool constructor may throw an exception under OSGi
> ---------------------------------------------------------------
>
> Key: POOL-338
> URL: https://issues.apache.org/jira/browse/POOL-338
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 2.4.2, 2.4.3, 2.5.0
> Environment: Java 8, Liferay DXP (an OSGi environment).
> Reporter: Michael C
> Assignee: Gary Gregory
> Priority: Major
> Fix For: 2.6.0
>
> Attachments: commons-pool-2.5.1.patch, commons-pool-2.6.0.patch,
> commons-pool-gg.patch, commons-pool-mc.patch
>
>
> Version 2.4.3 GenericObjectPool constructor throws this exception:
> {{java.lang.IllegalArgumentException:
> [org.apache.commons.pool2.impl.DefaultEvictionPolicy] does not implement
> EvictionPolicy}}
> {{ at
> org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:618)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:318)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:115)}}
> {{ at
> org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:88)}}
>
> Version 2.5.0 throws the same exception. Version 2.4.2 or older's
> setEvictionPolicyClassName method fail silently for the same reason. This
> line in BaseGenericObjectPool evaluates to false for all versions:
> {{ if (policy instanceof EvictionPolicy<?>) {}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
