[
https://issues.apache.org/jira/browse/CODEC-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492570#comment-16492570
]
Oscar Luis Vera Pérez edited comment on CODEC-246 at 5/28/18 11:31 AM:
-----------------------------------------------------------------------
I was trying to make the pull request but I ran into an issue:
This test case involves several string pairs. Apparently, it is testing pairs
where isEncodeEqual should return true. It is not the case for the very first
pair : "Meyer", "M\u00fcller".
Is this pair reflecting an existing bug in ColognePhonetic.colognePhonetic
method?
Is it a wrong pair?
Is this the reason why this test has no assertion?
was (Author: oscarlvp):
I wus trying to make the pull request but I ran into an issue:
This test case involves several string pairs. Apparently, it is testing pairs
where isEncodeEqual should return true. It is not the case for the very first
pair : "Meyer", "M\u00fcller".
Is this pair reflecting an existing bug in ColognePhonetic.colognePhonetic
method?
Is it a wrong pair?
Is this the reason why this test has no assertion?
> ColognePhoneticTest.testIsEncodeEquals missing assertions
> ---------------------------------------------------------
>
> Key: CODEC-246
> URL: https://issues.apache.org/jira/browse/CODEC-246
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Oscar Luis Vera Pérez
> Priority: Trivial
>
> The test method ColognePhoneticTest.isEncodeEquals misses an assertion to
> properly verify the ColognePhonetic.isEncodeEquals method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
