[ 
https://issues.apache.org/jira/browse/GEOMETRY-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536382#comment-16536382
 ] 

Matt Juntunen commented on GEOMETRY-7:
--------------------------------------

[~erans], this is done except for some additional javadocs that I need to add. 
I have two general questions for you, though:
 # I named the main classes PolarCoordinates and SphericalCoordinates but those 
seem kind of verbose to me now. Should we shorten it to Polar/Spherical or 
PolarCoords/SphericalCoords?
 #  I pulled out the two methods dealing with Jacobian and Hessian matrices 
from the old SphericalCoordinates class and put them in a new class named 
o.a.c.geometry.euclidean.threed.SphericalDerivativeConverter. The math involved 
here is a bit over my head so I'm not sure if this is a good name for the class 
or if the API is even useful. I really don't know what someone would use this 
for.

> Add Support for Polar and Spherical Coordinates
> -----------------------------------------------
>
>                 Key: GEOMETRY-7
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-7
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>
> Add support for Polar coordinates in Euclidean 2D space and Spherical 
> coordinates in Eucllidean 3D space. The coordinate classes should follow 
> VALJO guidelines 
> ([http://blog.joda.org/2014/03/valjos-value-java-objects.html]) and be 
> directly convertible to and from the corresponding Point/Vector types. The 
> API should look something like this:
>  
> {code:java}
> Polar polar = Polar.of(1, Math.PI / 2);
> polar.getRadius(); // 1
> polar.getTheta(); // 2
> Vector2D vec = Vector2D.ofPolar(polar);
> // also possible: Vector2D.ofPolar(1, Math.PI / 2)
> // do stuff with vec
> Polar result = vec.getPolar();{code}
>  
> For the Spherical component, the functionality should be merged with the 
> existing o.a.c.geometry.spherical.SphericalCoordinates class.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to