[ 
https://issues.apache.org/jira/browse/LANG-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544150#comment-16544150
 ] 

Sebb commented on LANG-1404:
----------------------------

LANG is for general purpose routines.

I think what you need is a domain-specific method.
It should check for 0, 1, null and return the appropriate bool.
Any other value should fail as it implies a coding bug.

This can then be documented with details of the convention that is being used, 
and pointers to any existing documentation on the convention.

> BooleanUtils.toBoolean(Integer) method added
> --------------------------------------------
>
>                 Key: LANG-1404
>                 URL: https://issues.apache.org/jira/browse/LANG-1404
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Ruslan Sibgatullin
>            Priority: Minor
>
> Right now to convert an Integer to boolean there is either a null check 
> needed:
> {{final Integer value = 1;}}
>  {{if (value != null) {}}
>  {{    if(BooleanUtils.toBoolean(value)) {}}
> {{        // some code}}
>       }
>  {{}}}
> or two methods call:
>  
> {{final Integer value = 1;}}
>  {{final Boolean b = BooleanUtils.toBooleanObject(value);}}
>  {{if (BooleanUtils.toBoolean(b)) {}}
>  {{    // some code}}
>  {{}}}
> Some code-sugar is added with the help of method that accepts Integer and 
> returns boolean:
> {{final Integer value = 1;}}
>  {{if (BooleanUtils.toBoolean(value)) {}}
>       // some code
>  {{}}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to