[
https://issues.apache.org/jira/browse/IMAGING-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551881#comment-16551881
]
ASF GitHub Bot commented on IMAGING-188:
----------------------------------------
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/34#discussion_r204226800
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
<version>2.6</version>
<scope>test</scope>
</dependency>
+ <!-- necessary modification of ImageIO for support of JPEG 2000 -->
+ <dependency>
+ <groupId>com.github.jai-imageio</groupId>
+ <artifactId>jai-imageio-jpeg2000</artifactId>
+ <version>1.3.0</version>
+ </dependency>
--- End diff --
Adding a dependency to `jai-imageio-jpeg2000` brings `jai-imageio-core` too
I believe. ImageIO and Commons Imaging share a lot of features. But, IMO,
adding a dependency from one to another, would be like adding TestNG as a
dependency in JUnit to get the TestNG groups feature.
A better approach, IMO, would be to build up the required code for JPEG2000
either within Commons Imaging or as a module. And then implement the rest of
the code as you have it here.
> ICNS Image Parser: Support for large Icons (ic07, ic08, ic09, ic10 [128px,
> 256px, 512px, 1024px]) and JPEG 2000
> ---------------------------------------------------------------------------------------------------------------
>
> Key: IMAGING-188
> URL: https://issues.apache.org/jira/browse/IMAGING-188
> Project: Commons Imaging
> Issue Type: New Feature
> Affects Versions: 1.0
> Environment: OS X
> Reporter: Marco Wagner
> Priority: Major
>
> I needed larger icons of icns files, so I edited the source code.
> See Pull Request.
> https://en.wikipedia.org/wiki/Apple_Icon_Image_format
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
