[
https://issues.apache.org/jira/browse/COLLECTIONS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552611#comment-16552611
]
ASF GitHub Bot commented on COLLECTIONS-691:
--------------------------------------------
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/45
After seeing the patch and pull request, I had to check the project to see
and try to understand why we had it that way in the first place. I couldn't
find an explanation. All tests pass before & after, and I think the change
looks OK.
Travis seems a bit upset about something, but probably not related to this
pull request. Running tests locally I get:
```bash
FO] Tests run: 337, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02
s - in org.apache.commons.collections4.multimap.UnmodifiableMultiValuedMapTest
[INFO] Running
org.apache.commons.collections4.multimap.HashSetValuedHashMapTest
[INFO] Tests run: 331, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.029 s - in org.apache.commons.collections4.multimap.HashSetValuedHashMapTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 32.684 s
[INFO] Finished at: 2018-07-23T22:07:45+12:00
[INFO] Final Memory: 32M/852M
[INFO]
------------------------------------------------------------------------
```
So +1. Approved PR, but will leave open in case others would like to have a
look too. I tried to think of ways in which it could be breaking API behaviour,
but I couldn't find a case where this change would alter existing user's code.
Thanks for your contributions @grimreaper !
> Use boolean operator for boolean result
> ---------------------------------------
>
> Key: COLLECTIONS-691
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-691
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Eitan Adler
> Priority: Minor
> Attachments: 0001-Use-boolean-operator-for-boolean-result.patch
>
>
> The code is confusing to read with a "|" where a "||" should be.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
