[jira] [Created] (COLLECTIONS-692) Replace use of deprecated Class#newInstance() #49

[Gary Gregory (JIRA)]

Gary Gregory created COLLECTIONS-692:
----------------------------------------

             Summary: Replace use of deprecated Class#newInstance() #49
                 Key: COLLECTIONS-692
                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-692
             Project: Commons Collections
          Issue Type: New Feature
            Reporter: Gary Gregory
            Assignee: Gary Gregory


Java 9 deprecates [SetUniqueList] Class#newInstance().

Fix two call sites:

- 
{{org.apache.commons.collections4.map.MultiValueMap.ReflectionFactory.create()}}
- 
{{org.apache.commons.collections4.list.SetUniqueList.createSetBasedOnList(Set<E>,
 List<E>)}}

The patch https://github.com/apache/commons-collections/pull/49 is incomplete 
and incorrect:

- Fix to 
{{org.apache.commons.collections4.map.MultiValueMap.ReflectionFactory.create()}}
 is missing
- Patch to 
{{org.apache.commons.collections4.list.SetUniqueList.createSetBasedOnList(Set<E>,
 List<E>)}} performs extra work by adding the initial values to the new set 
twice.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)