[
https://issues.apache.org/jira/browse/IO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560324#comment-16560324
]
Sebb commented on IO-582:
-------------------------
Oops, my bad, overlooked that.
However, I wonder whether it makes sense to have to override the nested
Observer class in order to use the ObservableInputStream.
Seems a bit messy.
Would it not be better to use an interface instead?
That aspect of the design can be changed now without breaking compatibility.
Once the methods are made protected they become part of the API.
> ObservableInputStream.Observer are package-private
> --------------------------------------------------
>
> Key: IO-582
> URL: https://issues.apache.org/jira/browse/IO-582
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
> Affects Versions: 2.6
> Reporter: Bruno Palos
> Assignee: Jochen Wiedmann
> Priority: Minor
> Fix For: 2.7
>
>
> Hi,
> According with the documentation of `ObservableInputStream` and
> `ObservableInputStream.Observer`, it should be possible to use those classes
> as part of the `commons-io` utilities. However,
> `ObservableInputStream.Observer`'s methods are package private and can't be
> extended outside the project's source code.
> My suggestion is to make `ObservableInputStream.Observer`'s methods protected.
> I'm happy to open a PR for this.
> Thank you
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
