[
https://issues.apache.org/jira/browse/DBCP-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584194#comment-16584194
]
Gary Gregory commented on DBCP-519:
-----------------------------------
The only method I see that does internal synchronization is
{{org.apache.commons.dbcp2.managed.TransactionRegistry.getActiveTransactionContext()}}
which syncs on {{this}}. All other uses of {{synchronized}} is done on method
signatures.
> Add some toString() methods for debugging (never printing user names and
> passwords)
> -----------------------------------------------------------------------------------
>
> Key: DBCP-519
> URL: https://issues.apache.org/jira/browse/DBCP-519
> Project: Commons DBCP
> Issue Type: Improvement
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Priority: Major
> Fix For: 2.6.0
>
>
> Add some toString() methods for debugging never printing user names and
> passwords:
> * org.apache.commons.dbcp2.cpdsadapter.DriverAdapterCPDS
> * org.apache.commons.dbcp2.cpdsadapter.PooledConnectionImpl
> * org.apache.commons.dbcp2.datasources.CPDSConnectionFactory
> * org.apache.commons.dbcp2.datasources.InstanceKeyDataSource
> * org.apache.commons.dbcp2.datasources.PerUserPoolDataSource
> * org.apache.commons.dbcp2.datasources.SharedPoolDataSource
> * org.apache.commons.dbcp2.datasources.UserPassKey (updated not to print
> passwords even though it was a char[] reference.)
> I went YAGNI here and only added what I needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
