[
https://issues.apache.org/jira/browse/VALIDATOR-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589158#comment-16589158
]
Sebb commented on VALIDATOR-424:
--------------------------------
Thanks. The patch does simplify the code.
However it does change the code of the weightedValue method called by
ISINCheckDigit.
I suspect the end result is the same, but this will need careful checking.
Also it drops the final qualifier from LuhnCheckDigit.
I'm not sure of the reason for using final, but just about all the other
classes have it.
I'm not sure the end result justifies the work involved.
> ISINCheckDigit could extend LuhnCheckDigit
> ------------------------------------------
>
> Key: VALIDATOR-424
> URL: https://issues.apache.org/jira/browse/VALIDATOR-424
> Project: Commons Validator
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Sebb
> Priority: Major
>
> ISINCheckDigit is a version of Luhn which allows alphabetic characters.
> The class could extend the Luhn class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
