[ 
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603825#comment-16603825
 ] 

ASF GitHub Bot commented on LANG-1416:
--------------------------------------

Github user smoyer64 commented on the issue:

    https://github.com/apache/commons-lang/pull/353
  
    @kinow I've found several areas where I think the tool can be improved but 
as an example of what a head start it provides I've spent a few minutes getting 
all the .../builder/... tests running.  The ``@Test`` annotation for the 
failing tests all contain an ``expect`` attribute and were fixed by wrapping 
the test body in an ``assertThrows`` statement.
    
    Some of the formatting changes are really unnecessary ... it seems that the 
tool analyzes all classes (not just those match the conventional naming 
patterns for tests.  It also rewrites classes that have no ``@Test`` 
annotations at all.  Jeanne presented this tool at JavaOne last year and she 
knew that it could be improved.  Perhaps I can convince her to move it to the 
JUnit Pioneer project!


> Update to JUnit 5
> -----------------
>
>                 Key: LANG-1416
>                 URL: https://issues.apache.org/jira/browse/LANG-1416
>             Project: Commons Lang
>          Issue Type: Task
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>            Priority: Major
>             Fix For: 3.9
>
>
> Once LANG-1415 is resolved we can start using the latest and greatest JUnit 
> version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to