[
https://issues.apache.org/jira/browse/TEXT-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609215#comment-16609215
]
ASF GitHub Bot commented on TEXT-139:
-------------------------------------
GitHub user nickwongwong opened a pull request:
https://github.com/apache/commons-text/pull/88
[TEXT-139] Improve JaccardSimilarity computational cost.
finish https://issues.apache.org/jira/projects/TEXT/issues/TEXT-139
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwongwong/commons-text master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 17a395c71685e6f9e9afab67d391f0b31fadd49a
Author: nickwongwong <a465625179@...>
Date: 2018-09-10T13:35:47Z
[TEXT-139] Improve JaccardSimilarity computational cost.
----
> Improve JaccardSimilarity computational cost
> --------------------------------------------
>
> Key: TEXT-139
> URL: https://issues.apache.org/jira/browse/TEXT-139
> Project: Commons Text
> Issue Type: Improvement
> Reporter: nick wong
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Improve JaccardSimilarity computational cost from O(n*m) to O(n+m).
> I found two unnecessary loops in
> JaccardSimilarity.calculateJaccardSimilarity() which can easy to be Improve.
> I would make a PR soon.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
