[ 
https://issues.apache.org/jira/browse/GEOMETRY-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614938#comment-16614938
 ] 

Gilles commented on GEOMETRY-11:
--------------------------------

See also class 
[Precision|https://git1-us-west.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Precision.java;h=11fe704383e46ee421a1c0c344dd86d86a2bcdbc;hb=HEAD]
 from ["Commons Numbers"|http://commons.apache.org/proper/commons-numbers].

> Replace tolerance with GeometryContext
> --------------------------------------
>
>                 Key: GEOMETRY-11
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-11
>             Project: Apache Commons Geometry
>          Issue Type: Wish
>            Reporter: Matt Juntunen
>            Priority: Major
>
> All of the partitioning-related concrete classes (ex: Plane, PolygonsSet, 
> PolyhedronsSet, etc) use a double value named tolerance in order to address 
> issues with floating point accuracy. For example, when determining if a point 
> lies in a plane, the point does not need to lie exactly on the plane but just 
> be within +- tolerance distance from it. Code testing values against each 
> other using this tolerance is repeated throughout the code base (ex: x >= y - 
> tolerance). We should abstract the concept of the tolerance into a 
> GeometryContext class and provide methods for testing values against each 
> other using the tolerance. This will reduce the chance of bugs and will also 
> allow for more sophisticated handling of floating point accuracy later on.
> The GeometryContext class would be similar to the MathContext class used by 
> BigDecimal but would contain the logic for making comparisons in addition to 
> the configuration for the comparisons.
> {code:java}
> public class GeometryContext {
>    public GeometryContext(tolerance){...}
>    public double getTolerance(){ ... }
>    // return -1, 0, +1
>    public int compare(double a, double b) { ... }
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to