Github user aaabramov commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/357#discussion_r220096594
  
    --- Diff: src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java ---
    @@ -148,11 +153,27 @@ public void testAnyNotNull() {
             assertTrue(ObjectUtils.anyNotNull(null, null, null, null, FOO, 
BAR));
         }
     
    +    /**
    +     * Tests {@link ObjectUtils#anyNull(Object...)}.
    +     */
    +    @Test
    +    void testAnyNull() {
    +        assertTrue(ObjectUtils.anyNull((Object) null));
    +        assertTrue(ObjectUtils.anyNull(null, null, null));
    +
    +        assertFalse(ObjectUtils.anyNull());
    +        assertFalse(ObjectUtils.anyNull((Object[]) null));
    +        assertFalse(ObjectUtils.anyNull(FOO));
    +        assertFalse(ObjectUtils.anyNull(null, FOO, null));
    --- End diff --
    
    Should this really be `assertFalse`?
    `ObjectUtils.anyNull(null, null, null, null, FOO, BAR)` - should return 
`true`, because it has `null` elements in varargs.


---

Reply via email to