[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639951#comment-16639951
]
Alex D Herbert edited comment on RNG-57 at 10/5/18 4:13 PM:
------------------------------------------------------------
{quote}No need to insert paragraph formatting tags (<p>...</p>) in the Javadoc
{quote}
Thanks for pointing that out. I add them everywhere out of habit.
Updated:
I've changed my mind about removing them if the {{/** ... */}} tags are used
since the comment is still rendered as if it was Javadoc by Eclipse. It may be
the same for other IDEs. This means that someone working on the code knows what
the field is for without having to go to the source line number.
I changed them to:
{code:java}
/**
* Some text.
*
* <p>Some more text.
*/
{code}
I can remove the {{<p>}} if it really bothers you.
was (Author: alexherbert):
{quote}No need to insert paragraph formatting tags (<p>...</p>) in the
Javadoc{quote}
Thanks for pointing that out. I add them everywhere out of habit.
> CachedUniformRandomProvider for nextBoolean() and nextInt()
> -----------------------------------------------------------
>
> Key: RNG-57
> URL: https://issues.apache.org/jira/browse/RNG-57
> Project: Commons RNG
> Issue Type: Improvement
> Components: sampling
> Affects Versions: 1.2
> Reporter: Alex D Herbert
> Priority: Minor
> Labels: performance
>
> Implement a wrapper around a {{UniformRandomProvider}} that can cache the
> underlying source of random bytes for use in the methods {{nextBoolean()}}
> and {{nextInt()}} (in the case of {{LongProvider}}). E.g.
> {code:java}
> LongProvider provider = RandomSource.create(RandomSource.SPLIT_MIX_64);
> CachedLongProvider rng = new CachedLongProvider(provider);
> // Uses cached nextLong() 64 times
> rng.nextBoolean();
> // Uses cached nextLong() twice
> rng.nextInt();
> IntProvider provider = RandomSource.create(RandomSource.KISS);
> CachedIntProvider rng2 = new CachedIntProvider(provider);
> // Uses cached nextInt() 32 times
> rng2.nextBoolean();
> // This could be wrapped by a factory method:
> UniformRandomProvider rng = CachedUniformRandomProviderFactory.wrap(
> // Any supported source: IntProvider or LongProvider
> RandomSource.create(RandomSource...));
> {code}
> The implementation should be speed tested to determine the benefit for
> {{nextBoolean()}} and if {{nextInt()}} can be improved for {{LongProviders}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
