GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/367
Update event tests to JUnit Jupiter
Upgrade the tests in the event package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
While most of these changes are drop-in replacements with no functional
benefit, it is worth noting the tests that test thrown exceptions.
Prior to this patch, this package tested for exceptions in two ways,
neither of which are supported in JUnit Jupiter:
1. With the `expected` argument of the `org.junit.Test` annotation.
2. With the `org.junit.rules.ExpectedException` `@Rule`
Both of these usages were replaced with calls to
`org.junit.jupiter.api.Assertions#assertThrows`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang junit-jupiter-event
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #367
----
commit 762641dcdbae9456aa2b72ec8fa1baa0acab942f
Author: Allon Mureinik <mureinik@...>
Date: 2018-10-02T03:41:37Z
Update event tests to JUnit Jupiter
Upgrade the tests in the event package to use JUnit Jupiter as
part of the effort to remove the dependency on the Vintage Engine.
While most of these changes are drop-in replacements with no functional
benefit, it is worth noting the tests that test thrown excetpions.
Prior to this patch, this package tested for exceptions in two ways,
neither of which are supported in JUnit Jupiter:
1. With the "expected" argument of the org.junit.Test annotation.
2. With the org.junit.rules.ExpectedException @Rule
Both of these usages were replaced with calls to
org.junit.jupiter.api.Assertions#assertThrows.
----
---
