[ 
https://issues.apache.org/jira/browse/GEOMETRY-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654642#comment-16654642
 ] 

Matt Juntunen commented on GEOMETRY-23:
---------------------------------------

[~erans], I kept thinking about the point/vector thing after you mentioned it 
the other day so I tried it out and this is what I ended up with. Things seem 
considerably cleaner so it feels like a good choice, even though I was adamant 
about not doing it before. This also matches the design of most other geometry 
libraries I've seen. I'm interested to see what you think. I've added some 
documentation explaining the decision in 
{{org.apache.commons.geometry.euclidean.package-info.java}}. After this, I'll 
continue on GEOMETRY-14.

> Remove Euclidean Point Classes
> ------------------------------
>
>                 Key: GEOMETRY-23
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-23
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>
> Based on discussion of the current Point/Vector API in GEOMETRY-14 and 
> research into other geometric libraries, I think we should remove the 
> Euclidean Point?D classes and make Vector?D also implement Point. This will 
> end up being similar to the previous commons-math design but avoids the issue 
> raised in MATH-1284 since the Point and Vector interfaces are not related. 
> They just happen to be implemented by the same class, which we're calling 
> Vector?D since a vector can be used to indicate a point (by adding it to the 
> origin).
> In the course of trying this out this design, I ended up removing 7 classes 
> and simplifying several methods. I think that's a good indicator that this is 
> a good design choice.
>  
> Pull request: https://github.com/apache/commons-geometry/pull/15



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to