[ 
https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668233#comment-16668233
 ] 

Bruno P. Kinoshita commented on POOL-355:
-----------------------------------------

I think the bump to Java 8 makes sense - and agree with the comments in the 
[mailing list|https://markmail.org/thread/5pkntjtj5pcu36nv] about leaving it 
for the next release.

I'm +0 for the new method. It sounds harmless, but not a +1 simply because I 
would use a tool like Graphite/Prometheus to collect the value of 
`getNumActive` via JMX/Jolokia and perform the aggregation (e.g. 
sum/avg/latest/greatest) per data point (e.g. second/millisecond/minute/etc). 
But if adding the method brings little work to maintain, then looks like others 
could agree with [~graben]'s last comment. Just me 0.02 cents.

> Add maxNumActive to pool config
> -------------------------------
>
>                 Key: POOL-355
>                 URL: https://issues.apache.org/jira/browse/POOL-355
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Benjamin Graf
>            Priority: Minor
>
> To give a pool the "correct" size it is mandatory to know in which bounds 
> pooled object size is lying. Therefor a overall count of historical maximum 
> of active objects sounds needed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to