[
https://issues.apache.org/jira/browse/CONFIGURATION-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692425#comment-16692425
]
Gary Gregory commented on CONFIGURATION-731:
--------------------------------------------
[~HCOONa],
Thank you for your new patch! :-)
I am having trouble applying your patch on top of svn {{trunk}}:
{noformat}
C:\vcs\svn\apache\commons\trunks-proper\vfs>svn patch
\temp\CONFIGURATION-731.002.patch.txt
C src\main\java\org\apache\commons\configuration2\INIConfiguration.java
> rejected hunk @@ -227,12 +227,12 @@
> rejected hunk @@ -256,6 +256,17 @@
> rejected hunk @@ -316,6 +327,86 @@
> rejected hunk @@ -530,7 +621,8 @@
> rejected hunk @@ -645,7 +737,7 @@
> rejected hunk @@ -672,9 +764,9 @@
> rejected hunk @@ -687,14 +779,14 @@
> rejected hunk @@ -774,13 +866,14 @@
Summary of conflicts:
Text conflicts: 1{noformat}
You you try a GitHub PR or make sure your patch is on top of svn trunk please?
Thank you!
Gary
> Allow user to specify the comments & separator chars
> ----------------------------------------------------
>
> Key: CONFIGURATION-731
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-731
> Project: Commons Configuration
> Issue Type: Improvement
> Components: Format
> Affects Versions: 2.4
> Reporter: Shuai Zhang
> Priority: Major
> Attachments: CONFIGURATION-731.001.patch, CONFIGURATION-731.002.patch
>
>
> Currently the INIConfiguration defined comments & separator chars as final
> static fields, which made it impossible for the user control the behavior of
> INIConfiguration parsing. I suggest making them as default value, open setter
> & getter methods for the comment & separator chars.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
