[
https://issues.apache.org/jira/browse/RNG-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697101#comment-16697101
]
ASF GitHub Bot commented on RNG-64:
-----------------------------------
GitHub user aherbert opened a pull request:
https://github.com/apache/commons-rng/pull/16
RNG-64: Created SubsetSampler utility class
Move shared code from the PermutationSampler and CombinationSampler to
the utility class.
Test the PermuationSampler with k < n.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aherbert/commons-rng improvement-RNG-64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-rng/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit e060199944ffea5851d79bd28b17a3e1a235429a
Author: Alex Herbert <a.herbert@...>
Date: 2018-11-23T12:51:13Z
RNG-64: Created SubsetSampler utility class
Move shared code from the PermutationSampler and CombinationSampler to
the utility class.
Test the PermuationSampler with k < n.
----
> SubsetSampler utility class
> ---------------------------
>
> Key: RNG-64
> URL: https://issues.apache.org/jira/browse/RNG-64
> Project: Commons RNG
> Issue Type: Improvement
> Components: sampling
> Affects Versions: 1.2
> Reporter: Alex D Herbert
> Priority: Minor
>
> Move shared code from the PermutationSampler and CombinationSampler to a
> utility class.
> This will modify the PermutationSampler to do a partial shuffle to generate a
> sample. This requires that a test should be added for the PermutationSampler
> for testing uniformity of a subset where k < n.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
