[
https://issues.apache.org/jira/browse/IO-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703295#comment-16703295
]
ASF GitHub Bot commented on IO-592:
-----------------------------------
GitHub user rerewww opened a pull request:
https://github.com/apache/commons-io/pull/71
[IO-592] Modified FileUtilsDirectoryContainsTestCase File
- Add directory is null test case in FileUtilsDirectoryContainsTestCase
- The exception case has modified with meaningful verification
please review
thanks:)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerewww/commons-io IO-592-directoryContains
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-io/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 545644c3e69c9d39d83f84b108f6007717c18bb6
Author: rerewww <rerewww@...>
Date: 2018-11-29T14:49:20Z
IO-592: Modified FileUtilsDirectoryContainsTestCase File
- Add directory is null test case in FileUtilsDirectoryContainsTestCase
- The exception case has modified with meaningful verification
----
> Modified FileUtilsDirectoryContainsTestCase File
> ------------------------------------------------
>
> Key: IO-592
> URL: https://issues.apache.org/jira/browse/IO-592
> Project: Commons IO
> Issue Type: Task
> Components: Utilities
> Reporter: sangwoo son
> Priority: Minor
> Fix For: 2.7
>
>
> * no test code for when directory is null in directoryContains method
> * I think the validation phase of the test case that generates the exception
> is not correct
> send
> I'll send pull request
> please review
> thanks :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
