rosti-il commented on a change in pull request #392: LANG-1410: eliminate one
unnecessary local int variable and add more tests
URL: https://github.com/apache/commons-lang/pull/392#discussion_r242420905
##########
File path:
src/test/java/org/apache/commons/lang3/StringUtilsEmptyBlankTest.java
##########
@@ -99,6 +110,7 @@ public void testIsNotBlank() {
assertFalse(StringUtils.isNotBlank(null));
assertFalse(StringUtils.isNotBlank(""));
assertFalse(StringUtils.isNotBlank(StringUtilsTest.WHITESPACE));
+ assertTrue(StringUtils.isNotBlank("a"));
Review comment:
This is a special case that fails if you accidentally use `index > 0`
instead of `index >= 0` in the expression of the down going loop. The next line
will not fail in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
