[
https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768161#comment-16768161
]
Sven Rathgeber commented on GEOMETRY-43:
----------------------------------------
I added a pull request : [https://github.com/apache/commons-geometry/pull/28]
getOffset should definitely not return -1 :) .... I would favour an
Optional.empty, instead of an exception, since the behaviour is not really
exceptional. It just
makes no sense. It would also be more stream friendly.
> Check unit test - line intersecting cube (line lies on a plane)
> ---------------------------------------------------------------
>
> Key: GEOMETRY-43
> URL: https://issues.apache.org/jira/browse/GEOMETRY-43
> Project: Apache Commons Geometry
> Issue Type: Task
> Components: Euclidean 3D
> Reporter: Sven Rathgeber
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Intersecting a cube with a Line (which lies on a plane) results in one
> intersection only.
>
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/23
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
