[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770787#comment-16770787
]
Sven Rathgeber commented on GEOMETRY-29:
----------------------------------------
That looks good and consistent to me.
{quote}I just had another thought in regard to the {{getOffset}} method: if we
interpret the method in a general sense as "give me the offset closest to zero
between two geometric elements" (ie, "what's the smallest distance between
them"), then the return value between two non-parallel lines in 2D or a
non-parallel line and plane in 3D would simply be zero, since the elements
intersect at some point. The value would also be zero for parallel elements
that coincide, but callers could use other methods if they need to distinguish
between these two states. This approach feels the cleanest and most consistent
to me so I think we should go that route.{quote}
Agreed !
> Plane API cleanup
> -----------------
>
> Key: GEOMETRY-29
> URL: https://issues.apache.org/jira/browse/GEOMETRY-29
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
>
> The following changes should be made to the
> {{o.a.c.g.euclidean.threed.Plane}} class:
> * make the class immutable
> * use well-named factory methods instead of constructor overloads
> * provide a factory method to create a plane with user-supplied {{u}} and
> {{v}} axes. The current implementation allows the normal to be provided but
> chooses its own planar axes (see {{setFrame}}).
> * add {{equals}}, {{hashCode}}, and {{toString}} methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
