[
https://issues.apache.org/jira/browse/TEXT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773427#comment-16773427
]
Bruno P. Kinoshita commented on TEXT-104:
-----------------------------------------
Hi [~jmkeil], good idea. There was some similar feedback in the commons-dev
list. So I prepared this pull request with a change that fixes the clirr report.
[https://github.com/apache/commons-text/pull/102]
Feel free to take a look and comment if that's OK or if there's anything
missing. [~szott] your change is still there, the new JaroWinklerSimilarity,
but the edit distance is still giving the wrong value (i.e. the similarity
score). I've added TODO notes, and will create a ticket if others are OK with
the pull request above, and it will be fixed in 2.0, as this is a behaviour and
binary change.
Cheers
Bruno
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Assignee: Bruno P. Kinoshita
> Priority: Trivial
> Fix For: 1.7
>
> Attachments: image-2019-02-20-20-32-41-512.png
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
